fix: same block core chain lock height - #979
Merged
Merged
Conversation
lklimek
reviewed
Apr 26, 2023
| // propose one | ||
| // This is done before all else | ||
|
|
||
| let core_chain_lock_update = match self.platform.core_rpc.get_best_chain_lock() { |
Contributor
There was a problem hiding this comment.
we should also check in ProcessProposal if received core chain lock height is valid
Member
Author
There was a problem hiding this comment.
Yeah there's a todo there already.
lklimek
approved these changes
Apr 26, 2023
HashEngineering
added a commit
to HashEngineering/platform
that referenced
this pull request
Aug 21, 2026
…68e652) Carries the wallet-scope born-spent attribution, the rescan reseed fix, and the repair-span bound into this branch's engine. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
HashEngineering
added a commit
to HashEngineering/platform
that referenced
this pull request
Aug 25, 2026
…th dev (a5d7ea0b) The dashpay#979 engine fixes and dashpay#974's coalesced committed-range sweeps now live on one rev: fix/key-wallet-rescan-changeset merged with dev, with the durable pending-sweep re-keyed to the coalesced model (manager-level swept-awaiting-commit receipt, resume-only seeding). Replaces the two superseded pins this branch carried (6768f983, 9a68e652). The rev also carries rust-dashcore dashpay#981 (Mnemonic::from_phrase is now the auto-detecting parse), so the three parse_mnemonic_any_language wordlist walks (wallet_lifecycle, rs-platform-wallet-ffi derivation + identity_keys_from_mnemonic, rs-sdk-ffi signer_simple) collapse to thin delegates and the language-tagged test call sites drop the argument. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only